From f1885d0d09d5d94ad326f2257c9502b9545f0e79 Mon Sep 17 00:00:00 2001 From: Lukas Oesch Date: Tue, 17 Mar 2026 12:39:17 +0100 Subject: use const & wherever applicable --- kernel/filesystem/include/filesystem/custody.hpp | 6 +++--- kernel/filesystem/include/filesystem/device_file.hpp | 2 +- kernel/filesystem/include/filesystem/ext2/ext2_filesystem.hpp | 2 +- kernel/filesystem/include/filesystem/filesystem.hpp | 2 +- kernel/filesystem/include/filesystem/inode.hpp | 4 ++-- kernel/filesystem/include/filesystem/inode_file.hpp | 2 +- kernel/filesystem/include/filesystem/mount.hpp | 4 ++-- kernel/filesystem/include/filesystem/open_file_description.hpp | 3 ++- kernel/filesystem/include/filesystem/vfs.hpp | 2 +- 9 files changed, 14 insertions(+), 13 deletions(-) (limited to 'kernel/filesystem/include') diff --git a/kernel/filesystem/include/filesystem/custody.hpp b/kernel/filesystem/include/filesystem/custody.hpp index b6eae22..0124eb6 100644 --- a/kernel/filesystem/include/filesystem/custody.hpp +++ b/kernel/filesystem/include/filesystem/custody.hpp @@ -9,10 +9,10 @@ namespace filesystem { struct custody { - custody(kstd::shared_ptr parent, kstd::shared_ptr node); + custody(kstd::shared_ptr const & parent, kstd::shared_ptr const & node); - [[nodiscard]] auto get_inode() const -> kstd::shared_ptr; - [[nodiscard]] auto get_parent() const -> kstd::shared_ptr; + [[nodiscard]] auto get_inode() const -> kstd::shared_ptr const &; + [[nodiscard]] auto get_parent() const -> kstd::shared_ptr const &; private: kstd::shared_ptr m_parent; diff --git a/kernel/filesystem/include/filesystem/device_file.hpp b/kernel/filesystem/include/filesystem/device_file.hpp index 4dce37f..dad4ea5 100644 --- a/kernel/filesystem/include/filesystem/device_file.hpp +++ b/kernel/filesystem/include/filesystem/device_file.hpp @@ -13,7 +13,7 @@ namespace filesystem { struct device_file : file { - explicit device_file(kstd::shared_ptr device); + explicit device_file(kstd::shared_ptr const & device); auto open() -> void override; diff --git a/kernel/filesystem/include/filesystem/ext2/ext2_filesystem.hpp b/kernel/filesystem/include/filesystem/ext2/ext2_filesystem.hpp index dd52e72..37448a1 100644 --- a/kernel/filesystem/include/filesystem/ext2/ext2_filesystem.hpp +++ b/kernel/filesystem/include/filesystem/ext2/ext2_filesystem.hpp @@ -13,7 +13,7 @@ namespace filesystem::ext2 { struct ext2_filesystem : filesystem { - auto mount(kstd::shared_ptr device) -> int override; + auto mount(kstd::shared_ptr const & device) -> int override; auto lookup(inode const & parent, std::string_view name) -> inode * override; private: diff --git a/kernel/filesystem/include/filesystem/filesystem.hpp b/kernel/filesystem/include/filesystem/filesystem.hpp index eabefc0..934f883 100644 --- a/kernel/filesystem/include/filesystem/filesystem.hpp +++ b/kernel/filesystem/include/filesystem/filesystem.hpp @@ -14,7 +14,7 @@ namespace filesystem { virtual ~filesystem() = default; - virtual auto mount(kstd::shared_ptr device) -> int = 0; + virtual auto mount(kstd::shared_ptr const & device) -> int = 0; virtual auto lookup(inode const & parent, std::string_view name) -> inode * = 0; [[nodiscard]] auto root_inode() const -> inode const &; diff --git a/kernel/filesystem/include/filesystem/inode.hpp b/kernel/filesystem/include/filesystem/inode.hpp index 2b5ee6c..abfe2cf 100644 --- a/kernel/filesystem/include/filesystem/inode.hpp +++ b/kernel/filesystem/include/filesystem/inode.hpp @@ -14,7 +14,7 @@ namespace filesystem { inode() = default; explicit inode(inode_kind kind); - explicit inode(kstd::shared_ptr device); + explicit inode(kstd::shared_ptr const & device); [[nodiscard]] auto metadata() const -> inode_metadata; @@ -24,7 +24,7 @@ namespace filesystem [[nodiscard]] auto is_block_device() const -> bool; [[nodiscard]] auto major_device() const -> size_t; [[nodiscard]] auto minor_device() const -> size_t; - [[nodiscard]] auto backing_device() const -> kstd::shared_ptr; + [[nodiscard]] auto backing_device() const -> kstd::shared_ptr const &; auto read(void * buffer, size_t offset, size_t size) const -> size_t; auto write(void const * buffer, size_t offset, size_t size) -> size_t; diff --git a/kernel/filesystem/include/filesystem/inode_file.hpp b/kernel/filesystem/include/filesystem/inode_file.hpp index 512f51d..5f8a95e 100644 --- a/kernel/filesystem/include/filesystem/inode_file.hpp +++ b/kernel/filesystem/include/filesystem/inode_file.hpp @@ -12,7 +12,7 @@ namespace filesystem { struct inode_file : file { - explicit inode_file(kstd::shared_ptr inode); + explicit inode_file(kstd::shared_ptr const & inode); auto open() -> void override; diff --git a/kernel/filesystem/include/filesystem/mount.hpp b/kernel/filesystem/include/filesystem/mount.hpp index f28de74..46a68e2 100644 --- a/kernel/filesystem/include/filesystem/mount.hpp +++ b/kernel/filesystem/include/filesystem/mount.hpp @@ -11,10 +11,10 @@ namespace filesystem { struct mount { - mount(std::string_view const & path, kstd::shared_ptr fs); + mount(std::string_view const & path, kstd::shared_ptr const & fs); [[nodiscard]] auto path() const -> std::string_view; - [[nodiscard]] auto get_filesystem() const -> kstd::shared_ptr; + [[nodiscard]] auto get_filesystem() const -> kstd::shared_ptr const &; private: std::string_view m_path; diff --git a/kernel/filesystem/include/filesystem/open_file_description.hpp b/kernel/filesystem/include/filesystem/open_file_description.hpp index 035b0ee..5ff094d 100644 --- a/kernel/filesystem/include/filesystem/open_file_description.hpp +++ b/kernel/filesystem/include/filesystem/open_file_description.hpp @@ -2,6 +2,7 @@ #define TEACH_OS_KERNEL_FILESYSTEM_OPEN_FILE_DESCRIPTION_HPP #include "file.hpp" + #include #include @@ -10,7 +11,7 @@ namespace filesystem { struct open_file_description { - open_file_description(kstd::shared_ptr file); + open_file_description(kstd::shared_ptr const & file); ~open_file_description() = default; diff --git a/kernel/filesystem/include/filesystem/vfs.hpp b/kernel/filesystem/include/filesystem/vfs.hpp index 9c89044..e16a961 100644 --- a/kernel/filesystem/include/filesystem/vfs.hpp +++ b/kernel/filesystem/include/filesystem/vfs.hpp @@ -33,7 +33,7 @@ namespace filesystem }; vfs() = default; - auto make_device_node(kstd::shared_ptr device) -> void; + auto make_device_node(kstd::shared_ptr const & device) -> void; [[nodiscard]] auto resolve_path(std::string_view path) -> std::optional; kstd::shared_ptr m_root_fs; -- cgit v1.2.3