summaryrefslogtreecommitdiff
path: root/app
diff options
context:
space:
mode:
Diffstat (limited to 'app')
-rw-r--r--app/CMakeLists.txt1
-rw-r--r--app/include/turns/app/windows/participant_editor.hpp2
-rw-r--r--app/src/windows/participant_editor.cpp8
-rw-r--r--app/tests/windows/main.cpp17
-rw-r--r--app/tests/windows/participant_editor.cpp112
5 files changed, 124 insertions, 16 deletions
diff --git a/app/CMakeLists.txt b/app/CMakeLists.txt
index eaf16b6..1074038 100644
--- a/app/CMakeLists.txt
+++ b/app/CMakeLists.txt
@@ -68,6 +68,7 @@ install(FILES
add_executable("app-tests"
"tests/windows/main.cpp"
+ "tests/windows/participant_editor.cpp"
)
target_link_libraries("app-tests" PRIVATE
diff --git a/app/include/turns/app/windows/participant_editor.hpp b/app/include/turns/app/windows/participant_editor.hpp
index 38b1887..cfa2245 100644
--- a/app/include/turns/app/windows/participant_editor.hpp
+++ b/app/include/turns/app/windows/participant_editor.hpp
@@ -22,8 +22,6 @@ namespace turns::app::windows
auto present(Gtk::Widget * parent) -> void;
- auto set_title(Glib::ustring const & value) -> void;
-
auto signal_finished() -> signal_finished_type;
private:
diff --git a/app/src/windows/participant_editor.cpp b/app/src/windows/participant_editor.cpp
index 49809c6..dd21248 100644
--- a/app/src/windows/participant_editor.cpp
+++ b/app/src/windows/participant_editor.cpp
@@ -4,6 +4,7 @@
#include <print>
+#include <glibmm/i18n.h>
#include <gtkmm/editable.h>
#include <gtkmm/listboxrow.h>
@@ -26,7 +27,7 @@ namespace turns::app::windows
adw_spin_row_set_value(m_priority, m_participant->property_priority().get_value());
}
- adw_dialog_set_title(m_adw, obj ? lang::edit_participant : lang::add_participant);
+ adw_dialog_set_title(m_adw, _(obj ? lang::edit_participant : lang::add_participant));
m_finish->signal_clicked().connect(sigc::mem_fun(*this, &participant_editor::handle_finish_clicked));
}
@@ -35,11 +36,6 @@ namespace turns::app::windows
adw_dialog_present(m_adw, parent->gobj());
}
- auto participant_editor::set_title(Glib::ustring const & value) -> void
- {
- adw_dialog_set_title(m_adw, value.c_str());
- }
-
auto participant_editor::signal_finished() -> signal_finished_type
{
return m_signal_finished;
diff --git a/app/tests/windows/main.cpp b/app/tests/windows/main.cpp
index 8661153..a04a130 100644
--- a/app/tests/windows/main.cpp
+++ b/app/tests/windows/main.cpp
@@ -12,13 +12,14 @@
#include <glibmm/ustring.h>
#include <gtkmm/builder.h>
#include <gtkmm/button.h>
+#include <gtkmm/listbox.h>
#include <gtkmm/menubutton.h>
#include <gtkmm/widget.h>
namespace turns::app::windows::tests
{
- TEST_CASE("Newly constructed main window", "[windows]")
+ TEST_CASE("A freshly constructed main window", "[windows]")
{
auto locale = GENERATE("en_US.UTF-8", "de_CH.UTF-8");
setlocale(LC_ALL, locale);
@@ -26,46 +27,46 @@ namespace turns::app::windows::tests
auto builder = Gtk::Builder::create_from_resource("/ch/arknet/Turns/windows/main.ui");
auto instance = Gtk::Builder::get_widget_derived<main>(builder, "main");
- SECTION("construction via builder succeeds")
+ SECTION("was successfully constructed")
{
REQUIRE(instance);
}
- SECTION("the window sub-title is not empty")
+ SECTION("has a non-empty subtitle")
{
auto widget = builder->get_widget<Gtk::Widget>("title");
auto adw = ADW_WINDOW_TITLE(widget->gobj());
REQUIRE(adw_window_title_get_subtitle(adw));
}
- SECTION("the window sub-title is set according to the active language")
+ SECTION("has its subtitle set according to the active language")
{
auto widget = builder->get_widget<Gtk::Widget>("title");
auto adw = ADW_WINDOW_TITLE(widget->gobj());
REQUIRE(adw_window_title_get_subtitle(adw) == Glib::ustring{_(lang::no_active_turn_order)});
}
- SECTION("the window title is not empty")
+ SECTION("has a non-empty title")
{
auto widget = builder->get_widget<Gtk::Widget>("title");
auto adw = ADW_WINDOW_TITLE(widget->gobj());
REQUIRE(adw_window_title_get_title(adw));
}
- SECTION("the window title is set according to the active language")
+ SECTION("has its title set according to the active language")
{
auto widget = builder->get_widget<Gtk::Widget>("title");
auto adw = ADW_WINDOW_TITLE(widget->gobj());
REQUIRE(adw_window_title_get_title(adw) == Glib::ustring{_(lang::turns)});
}
- SECTION("the add_participant button has the correct tooltip")
+ SECTION("has its add_participant button's tooltip set according to the active language")
{
auto widget = builder->get_widget<Gtk::Button>("add_participant");
REQUIRE(widget->get_tooltip_text() == Glib::ustring{_(lang::add_participant)});
}
- SECTION("the open_main_menu button has the correct tooltip")
+ SECTION("as its open_main_menu button's tooltip set according to the active language")
{
auto widget = builder->get_widget<Gtk::MenuButton>("open_main_menu");
REQUIRE(widget->get_tooltip_text() == Glib::ustring{_(lang::main_menu)});
diff --git a/app/tests/windows/participant_editor.cpp b/app/tests/windows/participant_editor.cpp
new file mode 100644
index 0000000..15c9975
--- /dev/null
+++ b/app/tests/windows/participant_editor.cpp
@@ -0,0 +1,112 @@
+#include "turns/app/windows/participant_editor.hpp"
+
+#include "turns/domain/participant.hpp"
+#include "turns/lang/messages.hpp"
+
+#include <catch2/catch_test_macros.hpp>
+#include <catch2/generators/catch_generators.hpp>
+
+#include <string>
+
+#include <adwaita.h>
+#include <glibmm/i18n.h>
+#include <glibmm/ustring.h>
+#include <gtkmm/builder.h>
+#include <gtkmm/button.h>
+#include <gtkmm/listboxrow.h>
+#include <gtkmm/widget.h>
+#include <gtkmm/window.h>
+
+namespace turns::app::windows::tests
+{
+
+ TEST_CASE("A freshly constructed participant editor without a participant", "[windows]")
+ {
+ auto locale = GENERATE("en_US.UTF-8", "de_CH.UTF-8");
+ setlocale(LC_ALL, locale);
+
+ auto builder = Gtk::Builder::create_from_resource("/ch/arknet/Turns/windows/participant_editor.ui");
+ auto instance = Gtk::Builder::get_widget_derived<participant_editor>(builder, "participant_editor");
+ auto window = Gtk::Window{};
+
+ SECTION("was successfully constructed")
+ {
+ REQUIRE(instance);
+ }
+
+ SECTION("has a non-empty title")
+ {
+ auto widget = ADW_DIALOG(instance->gobj());
+ REQUIRE(adw_dialog_get_title(widget));
+ }
+
+ SECTION("has its title set according to the active language")
+ {
+ auto widget = ADW_DIALOG(instance->gobj());
+ REQUIRE(adw_dialog_get_title(widget) == Glib::ustring{_(lang::add_participant)});
+ }
+
+ SECTION("has an empty name field")
+ {
+ auto widget = GTK_EDITABLE(builder->get_widget<Gtk::ListBoxRow>("name")->gobj());
+ REQUIRE(Glib::ustring{gtk_editable_get_text(widget)}.empty());
+ }
+
+ SECTION("has a zero priority field")
+ {
+ auto widget = ADW_SPIN_ROW(builder->get_widget<Gtk::ListBoxRow>("priority")->gobj());
+ REQUIRE(adw_spin_row_get_value(widget) == 0);
+ }
+
+ SECTION("allows binding to the finished signal")
+ {
+ REQUIRE((instance->signal_finished().connect([](auto, auto){})).connected());
+ }
+ }
+
+ TEST_CASE("A freshly constructed participant editor with a participant", "[windows]")
+ {
+ auto locale = GENERATE("en_US.UTF-8", "de_CH.UTF-8");
+ setlocale(LC_ALL, locale);
+
+ auto participant = domain::participant::create("Qibi Babblebranch", 12);
+ auto builder = Gtk::Builder::create_from_resource("/ch/arknet/Turns/windows/participant_editor.ui");
+ auto instance = Gtk::Builder::get_widget_derived<participant_editor>(builder, "participant_editor", participant);
+ auto window = Gtk::Window{};
+
+ SECTION("was successfully constructed")
+ {
+ REQUIRE(instance);
+ }
+
+ SECTION("has a non-empty title")
+ {
+ auto widget = ADW_DIALOG(instance->gobj());
+ REQUIRE(adw_dialog_get_title(widget));
+ }
+
+ SECTION("has its title set according to the active language")
+ {
+ auto widget = ADW_DIALOG(instance->gobj());
+ REQUIRE(adw_dialog_get_title(widget) == Glib::ustring{_(lang::edit_participant)});
+ }
+
+ SECTION("has its name field set according to its participant")
+ {
+ auto widget = GTK_EDITABLE(builder->get_widget<Gtk::ListBoxRow>("name")->gobj());
+ REQUIRE(gtk_editable_get_text(widget) == participant->get_name());
+ }
+
+ SECTION("has its priority field set according to its participant")
+ {
+ auto widget = ADW_SPIN_ROW(builder->get_widget<Gtk::ListBoxRow>("priority")->gobj());
+ REQUIRE(adw_spin_row_get_value(widget) == participant->get_priority());
+ }
+
+ SECTION("allows binding to the finished signal")
+ {
+ REQUIRE((instance->signal_finished().connect([](auto, auto){})).connected());
+ }
+ }
+
+} // namespace turns::app::windows::tests \ No newline at end of file
generated by cgit v1.2.3 (git 2.25.1) at 2026-04-17 19:46:23 +0000