From 1e24d2b3cd4315fff4177c593bcfeef5b354f612 Mon Sep 17 00:00:00 2001 From: Felix Morgner Date: Sat, 29 Aug 2026 10:32:29 +0200 Subject: chore: apply stylistic cleanups --- kernel/kapi/devices/bus.cpp | 2 +- kernel/kapi/devices/device_registry.cpp | 2 +- kernel/kapi/filesystem.cpp | 8 ++++---- kernel/kapi/filesystem.tests.cpp | 3 ++- 4 files changed, 8 insertions(+), 7 deletions(-) (limited to 'kernel/kapi') diff --git a/kernel/kapi/devices/bus.cpp b/kernel/kapi/devices/bus.cpp index e4b5a2c5..300151d5 100644 --- a/kernel/kapi/devices/bus.cpp +++ b/kernel/kapi/devices/bus.cpp @@ -34,7 +34,7 @@ namespace kapi::devices } } - auto bus::add_child(kstd::shared_ptr child) -> void + auto bus::add_child(kstd::shared_ptr const & child) -> void { { auto guard = kstd::lock_guard{m_lock}; diff --git a/kernel/kapi/devices/device_registry.cpp b/kernel/kapi/devices/device_registry.cpp index 080ae39b..09da35ae 100644 --- a/kernel/kapi/devices/device_registry.cpp +++ b/kernel/kapi/devices/device_registry.cpp @@ -42,7 +42,7 @@ namespace kapi::devices return *instance; } - auto device_registry::add(kstd::shared_ptr device) -> bool + auto device_registry::add(kstd::shared_ptr const & device) -> bool { if (!device) { diff --git a/kernel/kapi/filesystem.cpp b/kernel/kapi/filesystem.cpp index 2f3c524e..8ebda7cc 100644 --- a/kernel/kapi/filesystem.cpp +++ b/kernel/kapi/filesystem.cpp @@ -38,7 +38,7 @@ namespace kapi::filesystem .and_then([](auto file_descriptor) { return kernel::vfs::open_file_table::get().add_file(file_descriptor); }); } - auto close(size_t file_descriptor) -> kstd::result + auto close(std::size_t file_descriptor) -> kstd::result { return kernel::vfs::open_file_table::get() .file(file_descriptor) @@ -47,21 +47,21 @@ namespace kapi::filesystem .and_then([=]() { return kernel::vfs::open_file_table::get().remove_file(file_descriptor); }); } - auto read(size_t file_descriptor, std::span buffer) -> kstd::result + auto read(std::size_t file_descriptor, std::span buffer) -> kstd::result { return kernel::vfs::open_file_table::get().file(file_descriptor).and_then([=](auto descriptor) { return descriptor->read(buffer); }); } - auto write(size_t file_descriptor, std::span buffer) -> kstd::result + auto write(std::size_t file_descriptor, std::span buffer) -> kstd::result { return kernel::vfs::open_file_table::get().file(file_descriptor).and_then([=](auto descriptor) { return descriptor->write(buffer); }); } - auto seek(size_t file_descriptor, kstd::offset offset, seek_origin origin) -> kstd::result + auto seek(std::size_t file_descriptor, kstd::offset offset, seek_origin origin) -> kstd::result { return kernel::vfs::open_file_table::get().file(file_descriptor).and_then([=](auto file) { return file->seek(offset, origin); diff --git a/kernel/kapi/filesystem.tests.cpp b/kernel/kapi/filesystem.tests.cpp index 6fa2de3d..efcb4fd3 100644 --- a/kernel/kapi/filesystem.tests.cpp +++ b/kernel/kapi/filesystem.tests.cpp @@ -258,7 +258,8 @@ SCENARIO_METHOD(kernel::tests::vfs::storage_boot_module_vfs_fixture, "Kapi files auto read_buffer = std::vector(4); auto bytes_read = kapi::filesystem::read(*fd, read_buffer); - std::string_view buffer_as_str{reinterpret_cast(read_buffer.data()), static_cast(*bytes_read)}; + std::string_view buffer_as_str{reinterpret_cast(read_buffer.data()), + static_cast(*bytes_read)}; REQUIRE(buffer_as_str == "Test"); REQUIRE(kapi::filesystem::close(*fd)); -- cgit v1.2.3