From b3209ac2564f21f3b78ecf5e0c05ca346a4a4276 Mon Sep 17 00:00:00 2001
From: Lukas Oesch <lukasoesch20@gmail.com>
Date: Tue, 28 Apr 2026 10:49:34 +0200
Subject: refactor inode kind

---
 kernel/src/filesystem/devfs/inode.cpp | 11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)

(limited to 'kernel/src/filesystem/devfs')

diff --git a/kernel/src/filesystem/devfs/inode.cpp b/kernel/src/filesystem/devfs/inode.cpp
index 0ed66ad..2029a7f 100644
--- a/kernel/src/filesystem/devfs/inode.cpp
+++ b/kernel/src/filesystem/devfs/inode.cpp
@@ -1,15 +1,9 @@
 #include <kernel/filesystem/devfs/inode.hpp>
 
-#include <kernel/filesystem/inode.hpp>
-
 #include <cstddef>
 
 namespace kernel::filesystem::devfs
 {
-  inode::inode()
-      : kernel::filesystem::inode(inode_kind::directory)
-  {}
-
   auto inode::read(void * /*buffer*/, size_t /*offset*/, size_t /*size*/) const -> size_t
   {
     return 0;
@@ -19,4 +13,9 @@ namespace kernel::filesystem::devfs
   {
     return 0;
   }
+
+  auto inode::is_directory() const -> bool
+  {
+    return true;
+  }
 }  // namespace kernel::filesystem::devfs
\ No newline at end of file
-- 
cgit v1.2.3


From 40fbefab704695b905e3de3e80668447cc64b20e Mon Sep 17 00:00:00 2001
From: Lukas Oesch <lukasoesch20@gmail.com>
Date: Sat, 2 May 2026 15:36:19 +0200
Subject: refactoring and extend tests

---
 kernel/src/filesystem/devfs/filesystem.tests.cpp | 2 +-
 kernel/src/filesystem/devfs/inode.tests.cpp      | 1 +
 2 files changed, 2 insertions(+), 1 deletion(-)

(limited to 'kernel/src/filesystem/devfs')

diff --git a/kernel/src/filesystem/devfs/filesystem.tests.cpp b/kernel/src/filesystem/devfs/filesystem.tests.cpp
index 2b6c09b..36cb411 100644
--- a/kernel/src/filesystem/devfs/filesystem.tests.cpp
+++ b/kernel/src/filesystem/devfs/filesystem.tests.cpp
@@ -47,7 +47,7 @@ SCENARIO_METHOD(kernel::tests::filesystem::storage_boot_module_fixture,
     {
       auto non_directory_inode = fs.lookup(fs.root_inode(), "ram0");
       REQUIRE(non_directory_inode != nullptr);
-      REQUIRE(!non_directory_inode->is_directory());
+      REQUIRE_FALSE(non_directory_inode->is_directory());
 
       auto result = fs.lookup(non_directory_inode, "anything");
       REQUIRE(result == nullptr);
diff --git a/kernel/src/filesystem/devfs/inode.tests.cpp b/kernel/src/filesystem/devfs/inode.tests.cpp
index 030d709..ae26e74 100644
--- a/kernel/src/filesystem/devfs/inode.tests.cpp
+++ b/kernel/src/filesystem/devfs/inode.tests.cpp
@@ -19,6 +19,7 @@ SCENARIO("Devfs inode creation", "[filesystem][devfs][inode]")
       REQUIRE(inode.is_directory());
       REQUIRE_FALSE(inode.is_device());
       REQUIRE_FALSE(inode.is_regular());
+      REQUIRE_FALSE(inode.is_symbolic_link());
     }
   }
 }
-- 
cgit v1.2.3