Merge branch 'fmorgner/lint-fixes' into 'develop-BA-FS26'

lint: fix some issues detected by clang-tidy

See merge request teachos/kernel!13

5 files changed, 14 insertions, 14 deletions

diff --git a/arch/x86_64/src/memory/region_allocator.cpp b/arch/x86_64/src/memory/region_allocator.cpp
index 2690a7c..4ee3ca4 100644
--- a/arch/x86_64/src/memory/region_allocator.cpp
+++ b/arch/x86_64/src/memory/region_allocator.cpp
@@ -85,14 +85,14 @@ namespace arch::memory
       {
         m_next_frame = m_kernel_end + 1;
         advanced = true;
-        break;
+        continue;
       }
 
       if (falls_within(m_next_frame, m_multiboot_start, m_multiboot_end))
       {
         m_next_frame = m_multiboot_end + 1;
         advanced = true;
-        break;
+        continue;
       }
 
       if (m_multiboot_information)
diff --git a/kapi/include/kapi/boot_module/boot_module.hpp b/kapi/include/kapi/boot_module/boot_module.hpp
index 729efc9..85a1ac5 100644
--- a/kapi/include/kapi/boot_module/boot_module.hpp
+++ b/kapi/include/kapi/boot_module/boot_module.hpp
@@ -14,9 +14,9 @@ namespace kapi::boot_modules
   // ! its name, virtual start address, and size.
   struct boot_module
   {
-    std::string_view name;
+    std::string_view name{};
     memory::linear_address start_address{};
-    size_t size;
+    std::size_t size{};
   };
 }  // namespace kapi::boot_modules
 
diff --git a/kapi/include/kapi/memory/address.hpp b/kapi/include/kapi/memory/address.hpp
index 3bef358..69fc7b9 100644
--- a/kapi/include/kapi/memory/address.hpp
+++ b/kapi/include/kapi/memory/address.hpp
@@ -33,7 +33,7 @@ namespace kapi::memory
   struct address
   {
     //! Construct a null-address.
-    constexpr explicit address() noexcept = default;
+    constexpr address() noexcept = default;
 
     //! Construct an address representing the given value.
     //!
diff --git a/libs/kstd/include/kstd/bits/shared_ptr.hpp b/libs/kstd/include/kstd/bits/shared_ptr.hpp
index ed23d29..6bce83f 100644
--- a/libs/kstd/include/kstd/bits/shared_ptr.hpp
+++ b/libs/kstd/include/kstd/bits/shared_ptr.hpp
@@ -250,7 +250,7 @@ namespace kstd
      *
      * @return Returns the object owned by *this, equivalent to *get().
      */
-    auto operator*() const -> T &
+    [[nodiscard]] auto operator*() const -> T &
     {
       return *pointer;
     }
@@ -260,7 +260,7 @@ namespace kstd
      *
      * @return Returns a pointer to the object owned by *this, i.e. get().
      */
-    auto operator->() const -> T *
+    [[nodiscard]] auto operator->() const -> T *
     {
       return pointer;
     }
@@ -270,7 +270,7 @@ namespace kstd
      *
      * @return Pointer to the managed object or nullptr if no object is owned.
      */
-    auto get() const -> T *
+    [[nodiscard]] auto get() const -> T *
     {
       return pointer;
     }
@@ -301,7 +301,7 @@ namespace kstd
      *
      * @return true if *this owns an object, false otherwise.
      */
-    explicit operator bool() const
+    [[nodiscard]] explicit operator bool() const
     {
       return pointer != nullptr;
     }
@@ -317,7 +317,7 @@ namespace kstd
     /**
      * @brief Compare nullptr with shared_ptr.
      */
-    friend auto operator==(std::nullptr_t, shared_ptr const & ptr) -> bool
+    [[nodiscard]] friend auto operator==(std::nullptr_t, shared_ptr const & ptr) -> bool
     {
       return ptr.pointer == nullptr;
     }
@@ -325,7 +325,7 @@ namespace kstd
     /**
      * @brief Defaulted three-way comparator operator.
      */
-    auto operator<=>(shared_ptr const & other) const = default;
+    [[nodiscard]] auto operator<=>(shared_ptr const & other) const = default;
 
   private:
     /**
diff --git a/libs/kstd/include/kstd/vector b/libs/kstd/include/kstd/vector
index 7568cb6..41b380e 100644
--- a/libs/kstd/include/kstd/vector
+++ b/libs/kstd/include/kstd/vector
@@ -85,7 +85,7 @@ namespace kstd
     vector(vector<value_type> const & other)
         : _size(other._size)
         , _capacity(other._capacity)
-        , _data(new value_type[_capacity]{})
+        , _data(new value_type[_capacity]())
     {
       std::ranges::copy(other, _data);
     }
@@ -104,7 +104,7 @@ namespace kstd
       delete[] _data;
       _size = other._size;
       _capacity = other._capacity;
-      _data = new value_type[_capacity]{};
+      _data = new value_type[_capacity]();
       std::ranges::copy(other, _data);
       return *this;
     }
@@ -490,7 +490,7 @@ namespace kstd
       }
 
       _capacity = new_capacity;
-      auto temp = new value_type[_capacity]{};
+      auto temp = new value_type[_capacity]();
       std::ranges::copy(begin(), end(), temp);
       delete[] _data;
       _data = temp;