use const & wherever applicable

19 files changed, 29 insertions, 28 deletions

diff --git a/kernel/devices/include/devices/storage/storage_management.hpp b/kernel/devices/include/devices/storage/storage_management.hpp
index 65211c8..f8ffda8 100644
--- a/kernel/devices/include/devices/storage/storage_management.hpp
+++ b/kernel/devices/include/devices/storage/storage_management.hpp
@@ -42,7 +42,7 @@ namespace devices::storage
      *
      * Assigns controller IDs (major number range and minors per device).
      */
-    auto add_controller(kstd::shared_ptr<storage_controller> controller) -> void;
+    auto add_controller(kstd::shared_ptr<storage_controller> const & controller) -> void;
 
     /**
      * @brief Return all registered storage controllers.
diff --git a/kernel/devices/src/storage/storage_management.cpp b/kernel/devices/src/storage/storage_management.cpp
index 00449fb..25885ad 100644
--- a/kernel/devices/src/storage/storage_management.cpp
+++ b/kernel/devices/src/storage/storage_management.cpp
@@ -50,7 +50,7 @@ namespace devices::storage
     return *active_storage_management;
   }
 
-  auto storage_management::add_controller(kstd::shared_ptr<storage_controller> controller) -> void
+  auto storage_management::add_controller(kstd::shared_ptr<storage_controller> const & controller) -> void
   {
     controller->set_ids(next_free_major++, MINORS_PER_DEVICE);
     m_controllers.push_back(controller);
diff --git a/kernel/filesystem/include/filesystem/custody.hpp b/kernel/filesystem/include/filesystem/custody.hpp
index b6eae22..0124eb6 100644
--- a/kernel/filesystem/include/filesystem/custody.hpp
+++ b/kernel/filesystem/include/filesystem/custody.hpp
@@ -9,10 +9,10 @@ namespace filesystem
 {
   struct custody
   {
-    custody(kstd::shared_ptr<custody> parent, kstd::shared_ptr<inode> node);
+    custody(kstd::shared_ptr<custody> const & parent, kstd::shared_ptr<inode> const & node);
 
-    [[nodiscard]] auto get_inode() const -> kstd::shared_ptr<inode>;
-    [[nodiscard]] auto get_parent() const -> kstd::shared_ptr<custody>;
+    [[nodiscard]] auto get_inode() const -> kstd::shared_ptr<inode> const &;
+    [[nodiscard]] auto get_parent() const -> kstd::shared_ptr<custody> const &;
 
   private:
     kstd::shared_ptr<custody> m_parent;
diff --git a/kernel/filesystem/include/filesystem/device_file.hpp b/kernel/filesystem/include/filesystem/device_file.hpp
index 4dce37f..dad4ea5 100644
--- a/kernel/filesystem/include/filesystem/device_file.hpp
+++ b/kernel/filesystem/include/filesystem/device_file.hpp
@@ -13,7 +13,7 @@ namespace filesystem
 {
   struct device_file : file
   {
-    explicit device_file(kstd::shared_ptr<devices::device> device);
+    explicit device_file(kstd::shared_ptr<devices::device> const & device);
 
     auto open() -> void override;
 
diff --git a/kernel/filesystem/include/filesystem/ext2/ext2_filesystem.hpp b/kernel/filesystem/include/filesystem/ext2/ext2_filesystem.hpp
index dd52e72..37448a1 100644
--- a/kernel/filesystem/include/filesystem/ext2/ext2_filesystem.hpp
+++ b/kernel/filesystem/include/filesystem/ext2/ext2_filesystem.hpp
@@ -13,7 +13,7 @@ namespace filesystem::ext2
 {
   struct ext2_filesystem : filesystem
   {
-    auto mount(kstd::shared_ptr<devices::device> device) -> int override;
+    auto mount(kstd::shared_ptr<devices::device> const & device) -> int override;
     auto lookup(inode const & parent, std::string_view name) -> inode * override;
 
   private:
diff --git a/kernel/filesystem/include/filesystem/filesystem.hpp b/kernel/filesystem/include/filesystem/filesystem.hpp
index eabefc0..934f883 100644
--- a/kernel/filesystem/include/filesystem/filesystem.hpp
+++ b/kernel/filesystem/include/filesystem/filesystem.hpp
@@ -14,7 +14,7 @@ namespace filesystem
   {
     virtual ~filesystem() = default;
 
-    virtual auto mount(kstd::shared_ptr<devices::device> device) -> int = 0;
+    virtual auto mount(kstd::shared_ptr<devices::device> const & device) -> int = 0;
     virtual auto lookup(inode const & parent, std::string_view name) -> inode * = 0;
 
     [[nodiscard]] auto root_inode() const -> inode const &;
diff --git a/kernel/filesystem/include/filesystem/inode.hpp b/kernel/filesystem/include/filesystem/inode.hpp
index 2b5ee6c..abfe2cf 100644
--- a/kernel/filesystem/include/filesystem/inode.hpp
+++ b/kernel/filesystem/include/filesystem/inode.hpp
@@ -14,7 +14,7 @@ namespace filesystem
   {
     inode() = default;
     explicit inode(inode_kind kind);
-    explicit inode(kstd::shared_ptr<devices::device> device);
+    explicit inode(kstd::shared_ptr<devices::device> const & device);
 
     [[nodiscard]] auto metadata() const -> inode_metadata;
 
@@ -24,7 +24,7 @@ namespace filesystem
     [[nodiscard]] auto is_block_device() const -> bool;
     [[nodiscard]] auto major_device() const -> size_t;
     [[nodiscard]] auto minor_device() const -> size_t;
-    [[nodiscard]] auto backing_device() const -> kstd::shared_ptr<devices::device>;
+    [[nodiscard]] auto backing_device() const -> kstd::shared_ptr<devices::device> const &;
 
     auto read(void * buffer, size_t offset, size_t size) const -> size_t;
     auto write(void const * buffer, size_t offset, size_t size) -> size_t;
diff --git a/kernel/filesystem/include/filesystem/inode_file.hpp b/kernel/filesystem/include/filesystem/inode_file.hpp
index 512f51d..5f8a95e 100644
--- a/kernel/filesystem/include/filesystem/inode_file.hpp
+++ b/kernel/filesystem/include/filesystem/inode_file.hpp
@@ -12,7 +12,7 @@ namespace filesystem
 {
   struct inode_file : file
   {
-    explicit inode_file(kstd::shared_ptr<inode> inode);
+    explicit inode_file(kstd::shared_ptr<inode> const & inode);
 
     auto open() -> void override;
 
diff --git a/kernel/filesystem/include/filesystem/mount.hpp b/kernel/filesystem/include/filesystem/mount.hpp
index f28de74..46a68e2 100644
--- a/kernel/filesystem/include/filesystem/mount.hpp
+++ b/kernel/filesystem/include/filesystem/mount.hpp
@@ -11,10 +11,10 @@ namespace filesystem
 {
   struct mount
   {
-    mount(std::string_view const & path, kstd::shared_ptr<filesystem> fs);
+    mount(std::string_view const & path, kstd::shared_ptr<filesystem> const & fs);
 
     [[nodiscard]] auto path() const -> std::string_view;
-    [[nodiscard]] auto get_filesystem() const -> kstd::shared_ptr<filesystem>;
+    [[nodiscard]] auto get_filesystem() const -> kstd::shared_ptr<filesystem> const &;
 
   private:
     std::string_view m_path;
diff --git a/kernel/filesystem/include/filesystem/open_file_description.hpp b/kernel/filesystem/include/filesystem/open_file_description.hpp
index 035b0ee..5ff094d 100644
--- a/kernel/filesystem/include/filesystem/open_file_description.hpp
+++ b/kernel/filesystem/include/filesystem/open_file_description.hpp
@@ -2,6 +2,7 @@
 #define TEACH_OS_KERNEL_FILESYSTEM_OPEN_FILE_DESCRIPTION_HPP
 
 #include "file.hpp"
+
 #include <kstd/memory>
 
 #include <cstddef>
@@ -10,7 +11,7 @@ namespace filesystem
 {
   struct open_file_description
   {
-    open_file_description(kstd::shared_ptr<file> file);
+    open_file_description(kstd::shared_ptr<file> const & file);
 
     ~open_file_description() = default;
 
diff --git a/kernel/filesystem/include/filesystem/vfs.hpp b/kernel/filesystem/include/filesystem/vfs.hpp
index 9c89044..e16a961 100644
--- a/kernel/filesystem/include/filesystem/vfs.hpp
+++ b/kernel/filesystem/include/filesystem/vfs.hpp
@@ -33,7 +33,7 @@ namespace filesystem
     };
 
     vfs() = default;
-    auto make_device_node(kstd::shared_ptr<devices::device> device) -> void;
+    auto make_device_node(kstd::shared_ptr<devices::device> const & device) -> void;
     [[nodiscard]] auto resolve_path(std::string_view path) -> std::optional<custody>;
 
     kstd::shared_ptr<ext2::ext2_filesystem> m_root_fs;
diff --git a/kernel/filesystem/src/custody.cpp b/kernel/filesystem/src/custody.cpp
index 7a58229..3a87345 100644
--- a/kernel/filesystem/src/custody.cpp
+++ b/kernel/filesystem/src/custody.cpp
@@ -8,7 +8,7 @@
 
 namespace filesystem
 {
-  custody::custody(kstd::shared_ptr<custody> parent, kstd::shared_ptr<inode> node)
+  custody::custody(kstd::shared_ptr<custody> const & parent, kstd::shared_ptr<inode> const & node)
       : m_parent(parent)
       , m_inode(node)
   {
@@ -18,12 +18,12 @@ namespace filesystem
     }
   }
 
-  auto custody::get_inode() const -> kstd::shared_ptr<inode>
+  auto custody::get_inode() const -> kstd::shared_ptr<inode> const &
   {
     return m_inode;
   }
 
-  auto custody::get_parent() const -> kstd::shared_ptr<custody>
+  auto custody::get_parent() const -> kstd::shared_ptr<custody> const &
   {
     return m_parent;
   }
diff --git a/kernel/filesystem/src/device_file.cpp b/kernel/filesystem/src/device_file.cpp
index 882c9b1..699c161 100644
--- a/kernel/filesystem/src/device_file.cpp
+++ b/kernel/filesystem/src/device_file.cpp
@@ -14,7 +14,7 @@
 
 namespace filesystem
 {
-  device_file::device_file(kstd::shared_ptr<devices::device> device)
+  device_file::device_file(kstd::shared_ptr<devices::device> const & device)
       : m_device(device)
   {
     if (!m_device)
diff --git a/kernel/filesystem/src/ext2/ext2_filesystem.cpp b/kernel/filesystem/src/ext2/ext2_filesystem.cpp
index 2ae5ab7..a82a098 100644
--- a/kernel/filesystem/src/ext2/ext2_filesystem.cpp
+++ b/kernel/filesystem/src/ext2/ext2_filesystem.cpp
@@ -10,7 +10,7 @@
 
 namespace filesystem::ext2
 {
-  auto ext2_filesystem::mount(kstd::shared_ptr<devices::device> device) -> int
+  auto ext2_filesystem::mount(kstd::shared_ptr<devices::device> const & device) -> int
   {
     if (!device)
     {
diff --git a/kernel/filesystem/src/inode.cpp b/kernel/filesystem/src/inode.cpp
index 10a9a30..231ee33 100644
--- a/kernel/filesystem/src/inode.cpp
+++ b/kernel/filesystem/src/inode.cpp
@@ -15,7 +15,7 @@ namespace filesystem
       : m_kind(kind)
   {}
 
-  inode::inode(kstd::shared_ptr<devices::device> device)
+  inode::inode(kstd::shared_ptr<devices::device> const & device)
       : m_kind(inode_kind::device)
       , m_device(device)
   {
@@ -79,7 +79,7 @@ namespace filesystem
     return m_device->minor();
   }
 
-  auto inode::backing_device() const -> kstd::shared_ptr<devices::device>
+  auto inode::backing_device() const -> kstd::shared_ptr<devices::device> const &
   {
     return m_device;
   }
diff --git a/kernel/filesystem/src/inode_file.cpp b/kernel/filesystem/src/inode_file.cpp
index b68b3ee..0b8bdf9 100644
--- a/kernel/filesystem/src/inode_file.cpp
+++ b/kernel/filesystem/src/inode_file.cpp
@@ -10,7 +10,7 @@
 
 namespace filesystem
 {
-  inode_file::inode_file(kstd::shared_ptr<inode> inode)
+  inode_file::inode_file(kstd::shared_ptr<inode> const & inode)
       : m_inode(inode)
   {
     if (!m_inode)
diff --git a/kernel/filesystem/src/mount.cpp b/kernel/filesystem/src/mount.cpp
index 53a8143..021b074 100644
--- a/kernel/filesystem/src/mount.cpp
+++ b/kernel/filesystem/src/mount.cpp
@@ -10,7 +10,7 @@
 
 namespace filesystem
 {
-  mount::mount(std::string_view const & path, kstd::shared_ptr<filesystem> fs)
+  mount::mount(std::string_view const & path, kstd::shared_ptr<filesystem> const & fs)
       : m_path(path)
       , m_filesystem(fs)
   {
@@ -25,7 +25,7 @@ namespace filesystem
     return m_path;
   }
 
-  auto mount::get_filesystem() const -> kstd::shared_ptr<filesystem>
+  auto mount::get_filesystem() const -> kstd::shared_ptr<filesystem> const &
   {
     return m_filesystem;
   }
diff --git a/kernel/filesystem/src/open_file_description.cpp b/kernel/filesystem/src/open_file_description.cpp
index 9ebf67d..cddee76 100644
--- a/kernel/filesystem/src/open_file_description.cpp
+++ b/kernel/filesystem/src/open_file_description.cpp
@@ -9,7 +9,7 @@
 
 namespace filesystem
 {
-  open_file_description::open_file_description(kstd::shared_ptr<file> file)
+  open_file_description::open_file_description(kstd::shared_ptr<file> const & file)
       : m_file(file)
       , m_offset(0)
   {
diff --git a/kernel/filesystem/src/vfs.cpp b/kernel/filesystem/src/vfs.cpp
index 578fde4..c0f1c3a 100644
--- a/kernel/filesystem/src/vfs.cpp
+++ b/kernel/filesystem/src/vfs.cpp
@@ -86,7 +86,7 @@ namespace filesystem
     return std::nullopt;
   }
 
-  auto vfs::make_device_node(kstd::shared_ptr<devices::device> device) -> void
+  auto vfs::make_device_node(kstd::shared_ptr<devices::device> const & device) -> void
   {
     if (!device)
     {
@@ -111,7 +111,7 @@ namespace filesystem
 
       if (entry != m_device_nodes.end())
       {
-        return custody{static_cast<kstd::shared_ptr<custody>>(nullptr), entry->value().node};
+        return custody{nullptr, entry->value().node};
       }
 
       return std::nullopt;