diff options
| author | Matteo Gmür <matteo.gmuer1@ost.ch> | 2024-11-12 10:24:12 +0000 |
|---|---|---|
| committer | Matteo Gmür <matteo.gmuer1@ost.ch> | 2024-11-12 10:24:12 +0000 |
| commit | 7db57d7a47671b4023e34413a2276611e1c65f72 (patch) | |
| tree | dedbf03b37e0e73dc747bead9d97c04597f94f31 /arch/x86_64/src/memory | |
| parent | 13887617b17d9387e218ce702087b6a7140af9bd (diff) | |
| download | teachos-7db57d7a47671b4023e34413a2276611e1c65f72.tar.xz teachos-7db57d7a47671b4023e34413a2276611e1c65f72.zip | |
Add comment to flush all and remove now redudant todos.
Diffstat (limited to 'arch/x86_64/src/memory')
| -rw-r--r-- | arch/x86_64/src/memory/paging/inactive_page_table.cpp | 1 | ||||
| -rw-r--r-- | arch/x86_64/src/memory/paging/page_entry.cpp | 1 |
2 files changed, 0 insertions, 2 deletions
diff --git a/arch/x86_64/src/memory/paging/inactive_page_table.cpp b/arch/x86_64/src/memory/paging/inactive_page_table.cpp index 8ebc8ce..4e0610e 100644 --- a/arch/x86_64/src/memory/paging/inactive_page_table.cpp +++ b/arch/x86_64/src/memory/paging/inactive_page_table.cpp @@ -12,7 +12,6 @@ namespace teachos::arch::memory::paging temporary_page & temporary_page) : page_table_level_4_frame{frame} { - // TODO: Here the exact same mapping code but it actually works?, is it the different frame? auto table = temporary_page.map_table_frame(page_table_level_4_frame, active_page_table); table.zero_entries(); table[511].set_entry(page_table_level_4_frame, entry::PRESENT | entry::WRITABLE); diff --git a/arch/x86_64/src/memory/paging/page_entry.cpp b/arch/x86_64/src/memory/paging/page_entry.cpp index ba3deb3..5aa0982 100644 --- a/arch/x86_64/src/memory/paging/page_entry.cpp +++ b/arch/x86_64/src/memory/paging/page_entry.cpp @@ -51,7 +51,6 @@ namespace teachos::arch::memory::paging { exception_handling::assert((frame.start_address() & ~PHYSICAL_ADDRESS_MASK) == 0, "[Paging Entry] Start address is not aligned with page"); - // TODO: Crash when trying to write invalid value at 0xffffff8657f5d5f0 flags = frame.start_address() | additional_flags.to_ulong(); } |