Merge branch 'fmorgner/clang-tidy-in-toolchain' into 'develop-BA-FS26'

build: add clang-tidy to toolchain

See merge request teachos/kernel!14

4 files changed, 3 insertions, 8 deletions

diff --git a/kernel/include/kernel/devices/block_device.hpp b/kernel/include/kernel/devices/block_device.hpp
index 2a6f061..fb7d104 100644
--- a/kernel/include/kernel/devices/block_device.hpp
+++ b/kernel/include/kernel/devices/block_device.hpp
@@ -23,11 +23,6 @@ namespace devices
     block_device(size_t major, size_t minor, std::string_view name, size_t block_size);
 
     /**
-     * @brief Virtual destructor for block device.
-     */
-    virtual ~block_device() = default;
-
-    /**
      * @brief Read data from the block at @p block_index into @p buffer.
      * @param block_index Zero-based block index.
      * @param buffer Destination buffer.
diff --git a/kernel/src/devices/storage/ram_disk/ram_disk_controller.cpp b/kernel/src/devices/storage/ram_disk/ram_disk_controller.cpp
index efb6256..f3e9f70 100644
--- a/kernel/src/devices/storage/ram_disk/ram_disk_controller.cpp
+++ b/kernel/src/devices/storage/ram_disk/ram_disk_controller.cpp
@@ -5,7 +5,6 @@
 #include "kernel/devices/storage/ram_disk/ram_disk_device.hpp"
 
 #include <kstd/memory>
-#include <kstd/print>
 
 #include <algorithm>
 #include <cstddef>
diff --git a/kernel/src/filesystem/vfs.cpp b/kernel/src/filesystem/vfs.cpp
index 2123fc7..4e0b6bf 100644
--- a/kernel/src/filesystem/vfs.cpp
+++ b/kernel/src/filesystem/vfs.cpp
@@ -12,7 +12,6 @@
 #include "kernel/filesystem/mount.hpp"
 #include "kernel/filesystem/open_file_description.hpp"
 
-#include <kstd/cstring>
 #include <kstd/memory>
 
 #include <algorithm>
diff --git a/kernel/src/main.cpp b/kernel/src/main.cpp
index 6ced18c..eb59402 100644
--- a/kernel/src/main.cpp
+++ b/kernel/src/main.cpp
@@ -51,7 +51,9 @@ auto run_test_code() -> void
   kstd::println("---");
 
   // write half of the file new
-  kstd::vector<std::byte> write_buffer{std::byte{0xBB}, std::byte{0xAA}};
+  auto const value1 = std::byte{0xAA};
+  auto const value2 = std::byte{0xBB};
+  kstd::vector<std::byte> write_buffer{value1, value2};
   auto written_bytes = fd->write(write_buffer.data(), write_buffer.size());
 
   kstd::println("written bytes: {}", written_bytes);