aboutsummaryrefslogtreecommitdiff
path: root/arch/x86_64/src/memory/paging
diff options
context:
space:
mode:
Diffstat (limited to 'arch/x86_64/src/memory/paging')
-rw-r--r--arch/x86_64/src/memory/paging/page_mapper.cpp14
-rw-r--r--arch/x86_64/src/memory/paging/page_table.cpp16
2 files changed, 19 insertions, 11 deletions
diff --git a/arch/x86_64/src/memory/paging/page_mapper.cpp b/arch/x86_64/src/memory/paging/page_mapper.cpp
index b8f6b89..75b17ff 100644
--- a/arch/x86_64/src/memory/paging/page_mapper.cpp
+++ b/arch/x86_64/src/memory/paging/page_mapper.cpp
@@ -14,15 +14,23 @@ namespace teachos::arch::memory::paging
return page_table_handle{active_page, page_table_handle::LEVEL4};
}
+ auto subtract_level(page_table_handle::level level) -> page_table_handle::level
+ {
+ exception_handling::assert(level != page_table_handle::LEVEL1,
+ "[Page table] Attemptd to decrement enum to value outside of range");
+ auto value = static_cast<std::underlying_type<page_table_handle::level>::type>(level);
+ return static_cast<page_table_handle::level>(--value);
+ }
+
auto translate_page(virtual_page page) -> std::optional<allocator::physical_frame>
{
auto current_handle = create_or_get();
- for (auto level = page_table_handle::LEVEL4; level != page_table_handle::LEVEL1; level--)
+ for (auto level = page_table_handle::LEVEL4; level != page_table_handle::LEVEL1; level = subtract_level(level))
{
auto next_handle = current_handle.next_table(page.get_level_index(level));
- // If the next table method failed then it is highly likely that it was a huge page and we therefore have to parse
- // the table differently. Therefore, we attempt to parse it using the method required by huge pages.
+ // If the next table method failed then it is highly likely that it was a huge page and we therefore have to
+ // parse the table differently. Therefore, we attempt to parse it using the method required by huge pages.
if (!next_handle)
{
return translate_huge_page(page);
diff --git a/arch/x86_64/src/memory/paging/page_table.cpp b/arch/x86_64/src/memory/paging/page_table.cpp
index 852bbd5..9c9ca76 100644
--- a/arch/x86_64/src/memory/paging/page_table.cpp
+++ b/arch/x86_64/src/memory/paging/page_table.cpp
@@ -47,14 +47,6 @@ namespace teachos::arch::memory::paging
///< virtual addresses for the level 1 page table.
};
- auto operator--(page_table_handle::level level, int) -> page_table_handle::level
- {
- exception_handling::assert(level != page_table_handle::LEVEL1,
- "[Page table] Attemptd to decrement enum to value outside of range");
- auto value = static_cast<std::underlying_type<page_table_handle::level>::type>(level);
- return static_cast<page_table_handle::level>(--value);
- }
-
auto page_table::zero_entries() -> void
{
constexpr size_t entry_amount = sizeof(entries) / sizeof(entries[0]);
@@ -117,4 +109,12 @@ namespace teachos::arch::memory::paging
}
auto page_table_handle::operator[](std::size_t index) const -> entry { return handle->operator[](index); }
+
+ auto operator--(page_table_handle::level value, int) -> page_table_handle::level
+ {
+ exception_handling::assert(value != page_table_handle::LEVEL1,
+ "[Page table] Attemptd to decrement enum to value outside of range");
+ auto new_value = static_cast<std::underlying_type<page_table_handle::level>::type>(value);
+ return static_cast<page_table_handle::level>(--new_value);
+ }
} // namespace teachos::arch::memory::paging