aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
-rw-r--r--kernel/kapi/filesystem.tests.cpp6
-rw-r--r--kernel/src/filesystem/vfs.cpp1
2 files changed, 5 insertions, 2 deletions
diff --git a/kernel/kapi/filesystem.tests.cpp b/kernel/kapi/filesystem.tests.cpp
index 8a532bb..1d1f8ee 100644
--- a/kernel/kapi/filesystem.tests.cpp
+++ b/kernel/kapi/filesystem.tests.cpp
@@ -161,14 +161,16 @@ SCENARIO_METHOD(kernel::tests::filesystem::storage_boot_module_vfs_fixture, "Kap
THEN("not opened files cannot be read from")
{
std::vector<std::byte> buffer(10);
- auto bytes_read = kapi::filesystem::read(999, buffer.data(), buffer.size());
+ auto const invalid_fd = 999uz;
+ auto bytes_read = kapi::filesystem::read(invalid_fd, buffer.data(), buffer.size());
REQUIRE(bytes_read < 0);
}
THEN("not opened files cannot be written to")
{
std::vector<std::byte> buffer(10);
- auto bytes_written = kapi::filesystem::write(999, buffer.data(), buffer.size());
+ auto const invalid_fd = 999uz;
+ auto bytes_written = kapi::filesystem::write(invalid_fd, buffer.data(), buffer.size());
REQUIRE(bytes_written < 0);
}
}
diff --git a/kernel/src/filesystem/vfs.cpp b/kernel/src/filesystem/vfs.cpp
index 19f5f48..b84f690 100644
--- a/kernel/src/filesystem/vfs.cpp
+++ b/kernel/src/filesystem/vfs.cpp
@@ -139,6 +139,7 @@ namespace kernel::filesystem
kstd::shared_ptr<filesystem> const & fs) -> void
{
auto mount_path = mount_point_dentry->get_full_path();
+ // TODO BA-FS26 refactoring, implement dentry lookup to get the parent mount...
auto parent_mount = m_mount_table.find_longest_prefix_mount(mount_path.view());
auto new_fs_root =