aboutsummaryrefslogtreecommitdiff
path: root/arch/x86_64/src/memory
diff options
context:
space:
mode:
authorFabian Imhof <fabian.imhof@ost.ch>2024-11-12 10:41:28 +0000
committerFabian Imhof <fabian.imhof@ost.ch>2024-11-12 10:41:28 +0000
commit38e5d23fb325c983751f5d3e4f54a60bf1b1e47a (patch)
tree9233dd8d3b28d9365d8722794cc2b74e9cfd197f /arch/x86_64/src/memory
parent9507633f04e672b3dadf1385b1562fb3101d0ea3 (diff)
parent7db57d7a47671b4023e34413a2276611e1c65f72 (diff)
downloadteachos-38e5d23fb325c983751f5d3e4f54a60bf1b1e47a.tar.xz
teachos-38e5d23fb325c983751f5d3e4f54a60bf1b1e47a.zip
Merge branch 'feat_memory_manager' of ssh://gitlab.ost.ch:45022/teachos/kernel into feat_memory_manager
Diffstat (limited to 'arch/x86_64/src/memory')
-rw-r--r--arch/x86_64/src/memory/paging/inactive_page_table.cpp1
-rw-r--r--arch/x86_64/src/memory/paging/page_entry.cpp1
2 files changed, 0 insertions, 2 deletions
diff --git a/arch/x86_64/src/memory/paging/inactive_page_table.cpp b/arch/x86_64/src/memory/paging/inactive_page_table.cpp
index 8ebc8ce..4e0610e 100644
--- a/arch/x86_64/src/memory/paging/inactive_page_table.cpp
+++ b/arch/x86_64/src/memory/paging/inactive_page_table.cpp
@@ -12,7 +12,6 @@ namespace teachos::arch::memory::paging
temporary_page & temporary_page)
: page_table_level_4_frame{frame}
{
- // TODO: Here the exact same mapping code but it actually works?, is it the different frame?
auto table = temporary_page.map_table_frame(page_table_level_4_frame, active_page_table);
table.zero_entries();
table[511].set_entry(page_table_level_4_frame, entry::PRESENT | entry::WRITABLE);
diff --git a/arch/x86_64/src/memory/paging/page_entry.cpp b/arch/x86_64/src/memory/paging/page_entry.cpp
index ba3deb3..5aa0982 100644
--- a/arch/x86_64/src/memory/paging/page_entry.cpp
+++ b/arch/x86_64/src/memory/paging/page_entry.cpp
@@ -51,7 +51,6 @@ namespace teachos::arch::memory::paging
{
exception_handling::assert((frame.start_address() & ~PHYSICAL_ADDRESS_MASK) == 0,
"[Paging Entry] Start address is not aligned with page");
- // TODO: Crash when trying to write invalid value at 0xffffff8657f5d5f0
flags = frame.start_address() | additional_flags.to_ulong();
}